Skip to content

feat: support numbering for preview images - #1895

Open
vmobilis wants to merge 7 commits into
leejet:masterfrom
vmobilis:patch-4
Open

feat: support numbering for preview images#1895
vmobilis wants to merge 7 commits into
leejet:masterfrom
vmobilis:patch-4

Conversation

@vmobilis

@vmobilis vmobilis commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Allow to use %d placeholder in a filename template of preview images.
Hires previews will use numbering, continuous with base resolution.

Video previews are unaffected.

Additional Information

Tested only on Android.
And thank you.

Checklist

@leejet leejet left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things:

  1. Could we only call format_frame_idx() when the filename actually contains a format specifier? Otherwise paths containing %% change even when numbering isn't requested.
  2. Could we keep the preview index consistent with --output? --output starts from 000, while previews currently start from 001.

@vmobilis

Copy link
Copy Markdown
Contributor Author

@leejet, you're right, done:

  1. added %d check;
  2. changed ++counter to counter++;
  3. added default .png extension.

@vmobilis
vmobilis requested a review from leejet August 26, 2026 06:29
@vmobilis vmobilis closed this Aug 26, 2026
@vmobilis
vmobilis deleted the patch-4 branch August 26, 2026 06:35
@vmobilis
vmobilis restored the patch-4 branch August 26, 2026 06:37
@vmobilis vmobilis reopened this Aug 26, 2026
@vmobilis

Copy link
Copy Markdown
Contributor Author

@leejet, after some thought, I've applied substitution to whole pathname (not just filename), because the save_results() below does the same at line 525 and it would be less intuitive to use different rules for similar paths (as with 0 and 1-based counters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants